Conversation
…Set default currency when selecting a country
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } catch (error) { | ||
| // Look for error text directly if no test ID is present | ||
| await expect(this.page.getByText(/Amount/i)).toBeVisible({ timeout: 5000 }); | ||
| } |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low test
| } catch (error) { | ||
| // Try alternative text | ||
| await expect(this.page.getByText('Select Currency')).toBeVisible({ timeout: 5000 }); | ||
| } |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low test
| } catch (error) { | ||
| state.error = { | ||
| type: OnRampErrorType.FAILED_TO_LOAD_COUNTRIES, | ||
| message: 'Failed to load countries' | ||
| }; | ||
| } |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
| } catch (error) { | ||
| state.error = { | ||
| type: OnRampErrorType.FAILED_TO_LOAD_COUNTRIES, | ||
| message: 'Failed to load countries defaults' | ||
| }; | ||
| } |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
| } catch (error) { | ||
| state.error = { | ||
| type: OnRampErrorType.FAILED_TO_LOAD_CURRENCIES, | ||
| message: 'Failed to load crypto currencies' | ||
| }; | ||
| state.purchaseCurrencies = []; | ||
| state.purchaseCurrency = undefined; | ||
| } |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
| } catch (error) { | ||
| state.error = { | ||
| type: OnRampErrorType.FAILED_TO_LOAD_CURRENCIES, | ||
| message: 'Failed to load fiat currencies' | ||
| }; | ||
| state.paymentCurrencies = []; | ||
| state.paymentCurrency = undefined; | ||
| } |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
| } catch (error) { | ||
| state.error = { | ||
| type: OnRampErrorType.FAILED_TO_LOAD_LIMITS, | ||
| message: 'Failed to load fiat limits' | ||
| }; | ||
| state.paymentCurrenciesLimits = []; | ||
| } |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
| } catch (error) { | ||
| if (!state.error) { | ||
| state.error = { | ||
| type: OnRampErrorType.FAILED_TO_LOAD, | ||
| message: 'Failed to load onramp data' | ||
| }; | ||
| } | ||
| } finally { |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
| } catch (error) { | ||
| return 'US'; | ||
| } |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| } catch (jsonError) { | ||
| // If JSON parsing fails, fall back to text | ||
| const errorText = await response.text(); | ||
|
|
||
| return Promise.reject(`Code: ${response.status} - ${response.statusText} - ${errorText}`); | ||
| } |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
| } catch (error) { | ||
| state.loading = false; | ||
| state.error = { | ||
| type: OnRampErrorType.FAILED_TO_LOAD_COUNTRIES, | ||
| message: 'Failed to load countries' | ||
| }; | ||
| } |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
There was a problem hiding this comment.
Bug: String Capitalization Behavior Change
The StringUtil.capitalize function now converts all characters after the first to lowercase. This is a breaking change, as it previously only capitalized the first character while preserving the original casing of the rest of the string. This affects existing functionality where original casing was expected (e.g., "iPhone" becomes "Iphone", "hELLO" becomes "Hello").
packages/common/src/utils/StringUtil.ts#L6-L7
appkit-react-native/packages/common/src/utils/StringUtil.ts
Lines 6 to 7 in 6224043
Was this report helpful? Give feedback by reacting with 👍 or 👎
Summary
Added onramp feature for Universal and EOA wallets